luci-mod-network: mptcp option uses '' instead of "off"#8586
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
@dangowrt can you confirm what the values should be? The wiki says otherwise. |
systemcrash
reviewed
Apr 26, 2026
In the mptcp options, "off" is the default option, which has the same effect as not defining it. Using '' will prevent unnecessary parameters from being written to the flash. Link https://openwrt.org/docs/guide-user/network/mptcp Signed-off-by: Andy Chiang <AndyChiang_git@outlook.com>
Failed checksIssues marked with an ❌ are failing checks. Commit ffd48fa
For more details, see the full job log. Something broken? Consider providing feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the mptcp options, "off" is the default option, which has the same effect as not defining it. Using '' will prevent unnecessary parameters from being written to the flash.
Link https://openwrt.org/docs/guide-user/network/mptcp
Pull request details
Description
Screenshot or video of changes (if applicable)
Maintainer (preferred)
@
Tested on
OpenWrt version: SNAPSHOT
LuCI version: master
Web browser(s): Chrome 147.0.7727.102
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.